Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subplot clip paths in AngularJS #509

Merged
merged 6 commits into from
May 5, 2016
Merged

Fix subplot clip paths in AngularJS #509

merged 6 commits into from
May 5, 2016

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented May 4, 2016 •
edited
Loading

@mdtusz clip paths and Drawing.setClipUrl should now go hand-in-hand.

See angular/angular.js#8934

TODO:

  • Figure out why one test is failing on CircleCI (I can't reproduce that failure locally 😠 ).

@etpinard etpinard added bug something broken status: reviewable labels May 4, 2016
etpinard added 2 commits May 5, 2016 11:20
@etpinard
make sure to remove <base> being test done()
e80602f
@etpinard
move clip paths tests to plot_interact suite:
b9f4160 
- for some reason the click paths tests were messing the
  state in such a way to make a double-click test fail
  (in click_test.js) on the CircleCI FF38.
- by moving those tests to plot_interact (as 'p' > 'c'), the
  problem is put to the side.
@etpinard etpinard merged commit e0d75fc into master May 5, 2016
@etpinard etpinard deleted the fix-clip-path-angular branch May 5, 2016 16:58
@etpinard etpinard mentioned this pull request Jun 30, 2017
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@etpinard