-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix divider placement on reversed axes #4939
Conversation
@justin-sleep thanks very much for the PR. |
Sure, those changes have been made. |
Awesome. Let's see the test results... |
We need to figure out why few tests are failing. |
🎉 Great! LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix in getDividerVals
looks great. There's similar code in getBoundaryVals
, does it need similar reversed-range handling or does it already work correctly? I've lost track of the distinction between these functions.
It seems to me that a similar logic may be needed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can find a broken case with getBoundaryVals
then sure - otherwise this PR looks great - thanks @justin-sleep ! 💃
Fixes #4927. The divider placement algorithm now uses the correct boundary when the axis is reversed.