Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using Attrs as the short form of Attributes everywhere #4100

Merged
merged 1 commit into from
Aug 2, 2019
Merged

using Attrs as the short form of Attributes everywhere #4100

merged 1 commit into from
Aug 2, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Aug 2, 2019

There were few cases in the code where Atts is used next to Attrs.
While both refer to Attributes the Atts forms are simply replaced in this PR.

@plotly/plotly_js

@etpinard
Copy link
Contributor

etpinard commented Aug 2, 2019

thanks 💃

@archmoj archmoj merged commit 6bc4fec into master Aug 2, 2019
@archmoj archmoj deleted the atts-to-attrs branch August 2, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @etpinard