Update modebar buttons when locale changes

[alexcjohnson]

Fixes #2484

@etpinard another quick one I didn't quite finish on bug day :)
FWIW it fixes not only the encouraged usage (Plotly.react) but also the old Plotly.plot call with new config.

[etpinard]

Beautiful fix 💃

[vdgodse]

@alexcjohnson Shouldn't it also check if event handlers were updated? Callbacks may need to be updated while using plotly with React hooks, so that it doesn't use stale values from the old closure. I ran into an issue where it seems like plotly is not updating the onClick handler for modebar buttons.

[alexcjohnson]

@vdgodse please file a new issue showing the misbehavior you've discovered, and we'll take a look. If at all possible, try to reduce it to plain javascript, ie Plotly.newPlot(...).then(...).then(() => Plotly.react(...)) as that's far easier to debug than issues inside a React build (and easier to share in Codepen or the like).

[vdgodse]

Sure. I'll open an issue once I reduce it to plain javaScript.

[vdgodse]

Sure. I'll open an issue once I reduce it to plain javaScript.

Update: Created an issue here along with codepen demo