New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blank editable legend item fixes #2587

Merged

alexcjohnson merged 1 commit into master from blank-legend-fix

Apr 27, 2018

Collaborator

alexcjohnson commented Apr 27, 2018

Fixes #2576

In editable mode, pads all blank or short legend items out to the length of the longest one (or 4 characters at least) - note this is the character length, not the svg text length which will usually be shorter.
groupby and regular traces work the same now - deleting the value completely leaves it blank, rather than reverting to the default like groupby had been doing.


          cleaner handling of empty legend items, and groupby consistent with r…

ba787a0

…egular

alexcjohnson added bug status: reviewable labels

Contributor

etpinard commented Apr 27, 2018

Looks good 💃

alexcjohnson merged commit de22310 into master

alexcjohnson deleted the blank-legend-fix branch

April 27, 2018 21:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug