Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #2512 - skip over BADNUM lonlat in scattermapbox select #2513

Merged
merged 1 commit into from
Mar 30, 2018
Merged

fixes #2512 - skip over BADNUM lonlat in scattermapbox select #2513

merged 1 commit into from
Mar 30, 2018

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard added bug something broken status: reviewable labels Mar 30, 2018
@alexcjohnson
Copy link
Collaborator

What if you have lon but not lat for a point, or vice versa? Is that case handled elsewhere?

@etpinard
Copy link
Contributor Author

Is that case handled elsewhere?

Yes, early on in calc ->

https://github.com/plotly/plotly.js/blob/master/src/traces/scattergeo/calc.js#L36-L37

and note that scattermapbox reuses the scattergeo calc method:

https://github.com/plotly/plotly.js/blob/master/src/traces/scattermapbox/index.js#L17

@alexcjohnson
Copy link
Collaborator

Excellent. 💃

@etpinard etpinard merged commit ffcdea9 into master Mar 30, 2018
@etpinard etpinard deleted the scattermapbox-select-null branch March 30, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etpinard @alexcjohnson