Support ragged tables and show full table borders #2511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2133 - allows ragged columns for both headers and cells, and even a mix of 1D and 2D - see the table_ragged mock
Fixes #2401 - how some sides of the table were often missing their border - I extended the




clippath
around each column to include space for the cell borders. This has some strange effects right now if you use different border widths per cell, see eg cell5
intable_ragged
:On master this still isn't what I'd call "right", but its quirks are at least a little subtler:
Semi-opaque borders (on this branch) do even weirder things:
That said semi-opaque borders already behave oddly on master:
I'm not sure it's worth doing any better right now, but some thoughts for future reference:
cc @etpinard - if you think it's worthwhile I can move the discussion ^^ into a separate issue and gather input from table users like Dash and editor folks...