Fix scattergl unselected marker opacity for array marker opacity traces #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
commented
Mar 27, 2018
| "size": 20, | ||
| "opacity": [0.9, 0.8, 0.7, 1, 0.6, 0.8] | ||
| }, | ||
| "selectedpoints": [1, 4, 2] |
There was a problem hiding this comment.
On master, this gives
where selectedpoints is essentially ignored.
src/traces/scattergl/convert.js
Outdated
|
|
||
| if(Array.isArray(trace.marker.opacity)) { | ||
| var mo = trace.marker.opacity; | ||
| opts.unselected.opacity = new Array(mo.length); |
There was a problem hiding this comment.
what if trace.unselected.marker.opacity is already defined?
There was a problem hiding this comment.
I guess that would override it. Good eye. Thanks!
etpinard
commented
Mar 27, 2018
| }, | ||
| "unselected": { | ||
| "marker": { | ||
| "opacity": 0 |
There was a problem hiding this comment.
Before this commit, this gave:
that is unselected.marker.opacity was overrode.
|
Looks great 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2500 by handling the case where
marker.opacityis an array and no[un]selectedattributes are set (more info here). To be merged in #2499 to not have to regenerate the baselines once in master.cc @dfcreative @alexcjohnson