Skip to content

Commit

Permalink
Added touchmove support to slider component
Browse files Browse the repository at this point in the history
See #5855
  • Loading branch information
keul committed Jul 27, 2021
1 parent bbeeda9 commit e9953c1
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 6 deletions.
1 change: 1 addition & 0 deletions draftlogs/5856_add.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Add touch support to slider [[#5856](https://github.com/plotly/plotly.js/pull/5856)]
23 changes: 17 additions & 6 deletions src/components/sliders/draw.js
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ function attachGripEvents(item, gd, sliderGroup) {
return sliderGroup.data()[0];
}

item.on('mousedown', function() {
function mouseDownHandler() {
var sliderOpts = getSliderOpts();
gd.emit('plotly_sliderstart', {slider: sliderOpts});

Expand All @@ -475,25 +475,36 @@ function attachGripEvents(item, gd, sliderGroup) {
handleInput(gd, sliderGroup, sliderOpts, normalizedPosition, true);
sliderOpts._dragging = true;

$gd.on('mousemove', function() {
function mouseMoveHandler() {
var sliderOpts = getSliderOpts();
var normalizedPosition = positionToNormalizedValue(sliderOpts, d3.mouse(node)[0]);
handleInput(gd, sliderGroup, sliderOpts, normalizedPosition, false);
});
}

$gd.on('mousemove', mouseMoveHandler);
$gd.on('touchmove', mouseMoveHandler);

$gd.on('mouseup', function() {
function mouseUpHandler() {
var sliderOpts = getSliderOpts();
sliderOpts._dragging = false;
grip.call(Color.fill, sliderOpts.bgcolor);
$gd.on('mouseup', null);
$gd.on('mousemove', null);
$gd.on('touchend', null);
$gd.on('touchmove', null);

gd.emit('plotly_sliderend', {
slider: sliderOpts,
step: sliderOpts.steps[sliderOpts.active]
});
});
});
}

$gd.on('mouseup', mouseUpHandler);
$gd.on('touchend', mouseUpHandler);
}

item.on('mousedown', mouseDownHandler);
item.on('touchstart', mouseDownHandler);
}

function drawTicks(sliderGroup, sliderOpts) {
Expand Down

0 comments on commit e9953c1

Please sign in to comment.