revert guiEdit and fixup autorange interactions for inside tick labels

plotly · Dec 1, 2020 · 999f877 · 999f877
1 parent 0e52adb
commit 999f877
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/plot_api/plot_api.js b/src/plot_api/plot_api.js
@@ -407,8 +407,8 @@ function insideTickLabelsAutorange(gd) {
     var obj = gd._fullLayout._insideTickLabelsAutorange;
     if(!obj) return;
 
+    relayout(gd, obj);
     gd._fullLayout._insideTickLabelsAutorangeDone = true;
-    return relayout(gd, obj);
 }
 
 function emitAfterPlot(gd) {
@@ -2448,8 +2448,6 @@ function update(gd, traceUpdate, layoutUpdate, _traces) {
  */
 function guiEdit(func) {
     return function wrappedEdit(gd) {
-        gd._fullLayout._insideTickLabelsAutorangeDone = false;
-
         gd._fullLayout._guiEditing = true;
         var p = func.apply(null, arguments);
         gd._fullLayout._guiEditing = false;

diff --git a/src/plot_api/subroutines.js b/src/plot_api/subroutines.js
@@ -674,6 +674,14 @@ exports.doAutoRangeAndConstraints = function(gd) {
 
     for(var i = 0; i < axList.length; i++) {
         ax = axList[i];
+
+        if(
+            gd._fullLayout._insideTickLabelsAutorangeDone &&
+            ((ax._anchorAxis || {}).ticklabelposition || '').indexOf('inside') !== -1
+        ) {
+            continue;
+        }
+
         if(!autoRangeDone[ax._id]) {
             autoRangeDone[ax._id] = 1;
             cleanAxisConstraints(gd, ax);