some DRYing in PlotSchema.get()

plotly · Mar 30, 2018 · 9162265 · 9162265
1 parent 419458c
commit 9162265
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/plot_api/plot_schema.js b/src/plot_api/plot_schema.js
@@ -487,13 +487,12 @@ function getLayoutAttributes() {
 
         if(!_module.layoutAttributes) continue;
 
-        if(_module.name === 'cartesian' || _module.name === 'splom') {
-            handleBasePlotModule(layoutAttributes, _module, 'xaxis');
-            handleBasePlotModule(layoutAttributes, _module, 'yaxis');
-        }
-        else {
+        if(Array.isArray(_module.attr)) {
+            for(var i = 0; i < _module.attr.length; i++) {
+                handleBasePlotModule(layoutAttributes, _module, _module.attr[i]);
+            }
+        } else {
             var astr = _module.attr === 'subplot' ? _module.name : _module.attr;
-
             handleBasePlotModule(layoutAttributes, _module, astr);
         }
     }

diff --git a/src/traces/splom/base_plot.js b/src/traces/splom/base_plot.js
@@ -221,6 +221,7 @@ function clean(newFullData, newFullLayout, oldFullData, oldFullLayout, oldCalcda
 
 module.exports = {
     name: SPLOM,
+    attr: Cartesian.attr,
     attrRegex: Cartesian.attrRegex,
     layoutAttributes: Cartesian.layoutAttributes,
     supplyLayoutDefaults: Cartesian.supplyLayoutDefaults,