Merge pull request #5909 from plotly/toggleitem-groupclick

Fix double click legends when groupclick is set to toggleitem
plotly · Aug 27, 2021 · 8050b27 · 8050b27
2 parents 8152107 + b08f108
commit 8050b27
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/draftlogs/#5909_fix.md b/draftlogs/#5909_fix.md
@@ -0,0 +1 @@
+ - Fix double click legends when `groupclick` is set to "toggleitem" [[#5909](https://github.com/plotly/plotly.js/pull/5909)]
diff --git a/src/components/legend/handle_click.js b/src/components/legend/handle_click.js
@@ -65,6 +65,8 @@ module.exports = function handleClick(g, gd, numClicks) {
     }
 
     function setVisibility(fullTrace, visibility) {
+        if(legendItem.groupTitle && !toggleGroup) return;
+
         var fullInput = fullTrace._fullInput;
         if(Registry.hasTransform(fullInput, 'groupby')) {
             var kcont = carrs[fullInput.index];
@@ -199,7 +201,7 @@ module.exports = function handleClick(g, gd, numClicks) {
                         // N.B. consider traces that have a set legendgroup as toggleable
                         notInLegend = (fullData[i].showlegend !== true && !fullData[i].legendgroup);
                         isInGroup = isClicked || (hasLegendgroup && fullData[i].legendgroup === legendgroup);
-                        setVisibility(fullData[i], ((isInGroup && toggleGroup) || notInLegend) ? true : otherState);
+                        setVisibility(fullData[i], (isInGroup || notInLegend) ? true : otherState);
                         break;
                 }
             }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		- Fix double click legends when `groupclick` is set to "toggleitem" [[#5909](https://github.com/plotly/plotly.js/pull/5909)]