autorange call to account extra pad for inside tick labels

plotly · Nov 18, 2020 · 74f594d · 74f594d
1 parent c262d4b
commit 74f594d
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 5 deletions.
diff --git a/src/plot_api/plot_api.js b/src/plot_api/plot_api.js
@@ -381,6 +381,7 @@ function plot(gd, data, layout, config) {
         // calculated. Would be much better to separate margin calculations from
         // component drawing - see https://github.com/plotly/plotly.js/issues/2704
         Plots.doAutoMargin,
+        insideTickLabelsAutorange,
         Plots.previousPromises
     );
 
@@ -395,6 +396,13 @@ function plot(gd, data, layout, config) {
     });
 }
 
+function insideTickLabelsAutorange(gd) {
+    var obj = gd._fullLayout._insideTickLabelsAutorange;
+    if(!obj) return;
+    gd._fullLayout._insideTickLabelsAutorangeDone = true;
+    return relayout(gd, obj);
+}
+
 function emitAfterPlot(gd) {
     var fullLayout = gd._fullLayout;
 

diff --git a/src/plots/cartesian/axes.js b/src/plots/cartesian/axes.js
@@ -3147,11 +3147,19 @@ axes.drawLabels = function(gd, ax, opts) {
         });
     }
 
-    if(
-        (ax._anchorAxis || {}).autorange &&
-        (ax.ticklabelposition || '').indexOf('inside') !== -1
-    ) {
-        seq.push(computeFinalTickLabelBoundingBoxes);
+    if(!gd._fullLayout._insideTickLabelsAutorangeDone) {
+        var anchorAxisAutorange = (ax._anchorAxis || {}).autorange;
+        if(
+            anchorAxisAutorange &&
+            (ax.ticklabelposition || '').indexOf('inside') !== -1
+        ) {
+            if(!fullLayout._insideTickLabelsAutorange) {
+                fullLayout._insideTickLabelsAutorange = {};
+            }
+            fullLayout._insideTickLabelsAutorange[ax._anchorAxis._name + '.autorange'] = anchorAxisAutorange;
+
+            seq.push(computeFinalTickLabelBoundingBoxes);
+        }
     }
 
     var done = Lib.syncOrAsync(seq);

diff --git a/test/image/baselines/ticklabelposition-1.png b/test/image/baselines/ticklabelposition-1.png
diff --git a/test/image/baselines/ticklabelposition-2.png b/test/image/baselines/ticklabelposition-2.png