Merge pull request #6304 from plotly/pie-rotation-angle

change valType of `rotation` in pie to be `angle`
plotly · Sep 20, 2022 · 4e262a5 · 4e262a5
2 parents f1f331d + 67d5cc0
commit 4e262a5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/draftlogs/6304_change.md b/draftlogs/6304_change.md
@@ -0,0 +1 @@
+ - Use valType of `angle` for `rotation` in `pie` [[#6304](https://github.com/plotly/plotly.js/pull/6304)]
diff --git a/src/traces/pie/attributes.js b/src/traces/pie/attributes.js
@@ -276,9 +276,7 @@ module.exports = {
         ].join(' ')
     },
     rotation: {
-        valType: 'number',
-        min: -360,
-        max: 360,
+        valType: 'angle',
         dflt: 0,
         editType: 'calc',
         description: [

diff --git a/test/plot-schema.json b/test/plot-schema.json
@@ -41143,9 +41143,7 @@
      "description": "Instead of the first slice starting at 12 o'clock, rotate to some other angle.",
      "dflt": 0,
      "editType": "calc",
-     "max": 360,
-     "min": -360,
-     "valType": "number"
+     "valType": "angle"
     },
     "scalegroup": {
      "description": "If there are multiple pie charts that should be sized according to their totals, link them by providing a non-empty group id here shared by every trace in the same group.",
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		- Use valType of `angle` for `rotation` in `pie` [[#6304](https://github.com/plotly/plotly.js/pull/6304)]