Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Fix werkzeug 2.1.0 import and skip calculation #82

Merged
merged 3 commits into from
Mar 30, 2022

Conversation

deepyaman
Copy link
Contributor

@deepyaman deepyaman commented Mar 30, 2022

Closes #83

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In dash we used the werkzeug debugger html in the dev tools ui. As it not used in here, we can remove that import and just use traceback module to get stacktrace.

@deepyaman
Copy link
Contributor Author

In dash we used the werkzeug debugger html in the dev tools ui. As it not used in here, we can remove that import and just use traceback module to get stacktrace.

Thank you for the explanation! Think I've made the changes accordingly.

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good, thank you.

@alexcjohnson
Copy link
Collaborator

Thank you @deepyaman 🙇

@alexcjohnson alexcjohnson merged commit f8ec1be into plotly:master Mar 30, 2022
@deepyaman deepyaman deleted the patch-1 branch March 30, 2022 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'get_current_traceback' from 'werkzeug.debug.tbtools'
3 participants