Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ComponentRegistry dist cache. #524

Merged
merged 3 commits into from
Jan 23, 2019
Merged

Remove ComponentRegistry dist cache. #524

merged 3 commits into from
Jan 23, 2019

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Jan 4, 2019

The cache was preventing the dist from changing after a "reset" of an application with different component libraries requirements running on the same process.

Fixes T4rk1n/pytest-dash#15

@T4rk1n T4rk1n requested a review from rmarren1 January 4, 2019 18:40
@T4rk1n T4rk1n requested a review from alexcjohnson January 23, 2019 16:11
@T4rk1n
Copy link
Contributor Author

T4rk1n commented Jan 23, 2019

@alexcjohnson Please review.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, doesn't look like too big a lift to have to recreate resources every time. Good call. 💃

@T4rk1n T4rk1n merged commit 8e62b13 into master Jan 23, 2019
@T4rk1n T4rk1n deleted the remove-registry branch January 23, 2019 17:15
AnnMarieW pushed a commit to AnnMarieW/dash that referenced this pull request Jan 6, 2022
Fixed debug title class name for default spinner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants