-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Initial version of updated code for R transpiler #449
Closed
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
e39bcf1
Initial version of updated code for R transpiler
23bb710
Fixed creation of R functions for components
9ce9509
Fixed creation of R functions for components, triple quote issue
ed5d5db
Edits related to PR comments
3df1cd6
Edited _all_keywords.py so R/Py kwlists similarly named.
451283f
Updated base_component.py kwlist >> python_keywords
5998545
Attempting to resolve pylint warnings
6606943
Resolve pylint warning by removing unused generate_class_r code
4575b9f
Updated base_component.py
9bb7603
Updated component_loader.py
f1e47f5
Merge branch 'master' into R
rpkyle f4cd844
Updated documentation for generate_classes_r
aae11d6
Updated base_component.py to support .Rd without roxygen2
62bf001
Updated component_loader.py to import generate_help_file_r
89b7b85
Updated component_loader.py and base_component.py
664e516
Modified base_component.py to address propNames resolution problem
3bf21b3
Updated keyword list to include R reserved words
84a6745
Changes to support transpiling of JSON>>R within Python
2a4ac5a
Changes to support transpiling of JSON>>R within Python
3341d8e
Restore export_string generation
0d7943d
Updates to component loader/base component
e182736
Merged RPK branch
13d0d71
Updates to generate_js_metadata_r
8a43d98
Removed external_url parsing
8d2d538
Clarified comments in code
008598f
Added statements to copy JS deps into inst/lib
918a073
Updated base_component.py
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
# This is a set of Python keywords that cannot be used as prop names. | ||
# Keywords for a particular version are obtained as follows: | ||
# >>> import keyword | ||
# >>> keyword.kwlist | ||
|
||
kwlist = set([ | ||
'and', | ||
'elif', | ||
'is', | ||
'global', | ||
'as', | ||
'in', | ||
'if', | ||
'from', | ||
'raise', | ||
'for', | ||
'except', | ||
'nonlocal', | ||
'pass', | ||
'finally', | ||
'print', | ||
'import', | ||
'True', | ||
'None', | ||
'return', | ||
'exec', | ||
'await', | ||
'else', | ||
'break', | ||
'not', | ||
'with', | ||
'class', | ||
'assert', | ||
'False', | ||
'yield', | ||
'try', | ||
'while', | ||
'continue', | ||
'del', | ||
'async', | ||
'or', | ||
'def', | ||
'lambda' | ||
]) | ||
|
||
# This is a set of R reserved words that cannot be used as function argument names. | ||
# | ||
# Reserved words can be obtained from R's help pages by executing the statement below: | ||
# > ?reserved | ||
|
||
r_keywords = set([ | ||
'if', | ||
'else', | ||
'repeat', | ||
'while', | ||
'function', | ||
'for', | ||
'in', | ||
'next', | ||
'break', | ||
'TRUE', | ||
'FALSE', | ||
'NULL', | ||
'Inf', | ||
'NaN', | ||
'NA', | ||
'NA_integer_', | ||
'NA_real_', | ||
'NA_complex_', | ||
'NA_character_', | ||
'...' | ||
]) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change this to
python_keywords
then to be consistent. I think we should do it here, it's only 4 lines and I don't think it needs its own PR.