Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all illegal characters in environment variable #39

Merged
merged 1 commit into from
Jun 27, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dash/dash.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from flask_compress import Compress
from flask_seasurf import SeaSurf
import os
import re
import importlib
import requests
import pkgutil
Expand Down Expand Up @@ -46,8 +47,8 @@ def __init__(
# If user supplied their own server, they might've supplied a
# secret_key with it
secret_key_name = 'dash_{}_secret_key'.format(
# TODO - check for other illegal characters
name.replace('.', '_')
# replace any invalid characters
re.sub('[\W_]+', '_', name)
)
secret_key = os.environ.get(
secret_key_name, SeaSurf()._generate_token()
Expand Down