Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url_base_pathname init configs #365

Merged
merged 4 commits into from
Sep 6, 2018
Merged

Fix url_base_pathname init configs #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35bcb9e
Set url_base_pathname default to None.
T4rk1n Sep 3, 2018
a32ae9e
dash-html-components==0.12.0
T4rk1n Sep 4, 2018
d5a3f58
Fix circle cache key.
T4rk1n Sep 4, 2018
9959758
Version bump.
T4rk1n Sep 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,12 @@ jobs:
name: Write deps cache key
command: cat "$REQUIREMENTS_FILE" > reqs.txt

- run:
name: Write job name
command: echo $CIRCLE_JOB > circlejob.txt

- restore_cache:
key: deps1-{{ .Branch }}-{{ checksum "reqs.txt" }}
key: deps1-{{ .Branch }}-{{ checksum "reqs.txt" }}-{{ checksum ".circleci/config.yml" }}-{{ checksum "circlejob.txt" }}

- run:
name: Install dependencies
Expand All @@ -27,7 +31,7 @@ jobs:
pip install -r $REQUIREMENTS_FILE

- save_cache:
key: deps1-{{ .Branch }}-{{ checksum "reqs.txt" }}
key: deps1-{{ .Branch }}-{{ checksum "reqs.txt" }}-{{ checksum ".circleci/config.yml" }}-{{ checksum "circlejob.txt" }}
paths:
- "venv"

Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.26.4 - 2018-08-28
## Fixed
- Set `url_base_pathname` to `None` in `Dash.__init__`. Fix [#364](https://github.com/plotly/dash/issues/364)

## 0.26.3 - 2018-08-27
## Fixed
- Prefix assets files with `requests_pathname_prefix`. [#351](https://github.com/plotly/dash/pull/351)
Expand Down
2 changes: 1 addition & 1 deletion dash/dash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def __init__(
assets_url_path='/assets',
assets_ignore='',
include_assets_files=True,
url_base_pathname='/',
url_base_pathname=None,
assets_external_path=None,
requests_pathname_prefix=None,
routes_pathname_prefix=None,
Expand Down
2 changes: 1 addition & 1 deletion dash/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '0.26.3'
__version__ = '0.26.4'
2 changes: 1 addition & 1 deletion dev-requirements-py37.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dash_core_components>=0.27.2
dash_html_components>=0.12.0rc3
dash_html_components>=0.12.0
dash-flow-example==0.0.3
dash-dangerously-set-inner-html
dash_renderer
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ appnope==0.1.0
backports.shutil-get-terminal-size==1.0.0
click==6.7
dash-core-components==0.3.3
dash-html-components==0.11.0rc1
dash-html-components==0.12.0
dash-renderer==0.2.9
dash.ly==0.14.0
decorator==4.0.11
Expand Down