Fixed bug in that user specified host/port/proxy were being overwritten #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the environment variables HOST, PORT and DASH_PROXY are fallbacks rather than overwriting the user specified arguments for host, port, proxy
trbedwards
requested review from
alexcjohnson,
T4rk1n,
ndrezn,
gvwilson and
emilykl
as code owners
gvwilson
added
P1
|
@T4rk1n if this looks good to you, can it go into the upcoming release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the environment variables HOST, PORT and DASH_PROXY are fallbacks rather than overwriting the user specified arguments for host, port, proxy.