Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for TypeScript 5.5 #2936

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Add Support for TypeScript 5.5 #2936

merged 5 commits into from
Aug 23, 2024

Conversation

samhinshaw
Copy link
Contributor

@samhinshaw samhinshaw commented Jul 30, 2024

TypeScript 5.5 adds a hard check to prevent ts.createProgam from being called on improperly parsed tsconfig files. Fortunately, the error message politely points out what function you can use to parse the tsconfig file. Hooray for code review! However, this change should be broadly backwards-compatible, as this function has been present in TypeScript since version 2.8.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks N/A
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR N/A

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows N/A

@samhinshaw samhinshaw force-pushed the feature/support-ts-5.5 branch from 35b2bac to ba7e585 Compare July 30, 2024 05:15
@samhinshaw samhinshaw marked this pull request as draft July 30, 2024 15:15
@gvwilson gvwilson added feature something new P2 considered for next cycle labels Aug 13, 2024
@samhinshaw samhinshaw force-pushed the feature/support-ts-5.5 branch from ba7e585 to 5390e4b Compare August 22, 2024 17:43
@samhinshaw samhinshaw marked this pull request as ready for review August 22, 2024 18:02
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@gvwilson
Copy link
Contributor

@T4rk1n can you please give this one last look and then merge? thank you - @gvwilson

@T4rk1n T4rk1n merged commit bcd9bd1 into dev Aug 23, 2024
3 checks passed
@T4rk1n T4rk1n deleted the feature/support-ts-5.5 branch August 23, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants