Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No console log #2146

Merged
merged 3 commits into from
Jul 21, 2022
Merged

No console log #2146

merged 3 commits into from
Jul 21, 2022

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Jul 18, 2022

  • Remove leftover debug console log
  • Add eslint rule to error on console.log for the renderer.

@T4rk1n T4rk1n requested a review from alexcjohnson as a code owner July 18, 2022 14:55
alexcjohnson
alexcjohnson approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@T4rk1n T4rk1n merged commit 61b40be into dev Jul 21, 2022
@T4rk1n T4rk1n deleted the no-console branch July 21, 2022 13:14
alexcjohnson referenced this pull request Aug 3, 2022
@T4rk1n
Manage previous outdated running jobs.
02c15dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T4rk1n @alexcjohnson