Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dropdown with a value but no options. #2065

Merged
merged 2 commits into from
May 24, 2022
Merged

Fix Dropdown with a value but no options. #2065

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c42b70
Fix Dropdown with a value but no options.
T4rk1n May 24, 2022
c2f046c
Update changelog.
T4rk1n May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/dash-core-components/src/fragments/Dropdown.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,11 @@ const Dropdown = props => {
);

useEffect(() => {
if (optionsCheck !== sanitizedOptions && !isNil(value)) {
if (
!isNil(sanitizedOptions) &&
optionsCheck !== sanitizedOptions &&
!isNil(value)
) {
const values = sanitizedOptions.map(option => option.value);
if (multi && Array.isArray(value)) {
const invalids = value.filter(v => !values.includes(v));
Expand Down
14 changes: 14 additions & 0 deletions components/dash-core-components/tests/integration/dropdown/test_dynamic_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,17 @@ def test_dddo002_array_comma_value(dash_dcc):
dash_dcc.wait_for_text_to_equal("#react-select-2--value-0", "San Francisco, CA\n ")

assert dash_dcc.get_logs() == []


def test_dddo003_value_no_options(dash_dcc):
app = Dash(__name__)

app.layout = html.Div(
[
dcc.Dropdown(value="foobar", id="dropdown"),
]
)

dash_dcc.start_server(app)
assert dash_dcc.get_logs() == []
dash_dcc.wait_for_element("#dropdown")