Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ci failures #2006

Merged
merged 29 commits into from
Apr 13, 2022
Merged

Fix ci failures #2006

merged 29 commits into from
Apr 13, 2022

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Apr 7, 2022

  • dash_duo ThreadRunner: Kill all new threads created during the tests.
  • Temporary fixes for a bug introduced in Werkzeug 2.1.0 update with the 204 responses that we return for the no_update callbacks.
    • Add pytest-rerunfailures to automatically reruns flaky tests.
    • Skip & xfail for the tests that are more prone to fails.

@T4rk1n T4rk1n requested a review from alexcjohnson as a code owner April 7, 2022 17:05
@alexcjohnson
Copy link
Collaborator

Any idea how adding one package to dash-table caused its package-lock to get 6000 lines SMALLER?

@alexcjohnson
Copy link
Collaborator

Ah now that the "deprecated SDK" banner is gone, percy has a new banner:
Screen Shot 2022-04-07 at 21 51 58

That said some of the snapshots look oddly empty - may be worth doing a bit of manual comparison of the old vs new and/or a comparison to what these look like when run locally, to see if there's something odd going on with the new snapshot framework.

alexcjohnson
alexcjohnson reviewed Apr 8, 2022
View reviewed changes
dash/testing/plugin.py Outdated
action="store",
default="tests/assets",
help="configure how Percy will discover your app's assets",
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the new percy runner have a different way of collecting assets so it doesn't need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that was specific to the old percy client, can't find something similar for the new one. Do you think it would be better to make the migrate in a separate PR with a proper percy baseline build to compare ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they can make do without that it's way better... let's just verify that assets like images are in fact making it into the snapshots, and keep going.

@T4rk1n T4rk1n force-pushed the fix-ci branch 4 times, most recently from f246801 to b06c700 Compare April 8, 2022 18:09
@alexcjohnson alexcjohnson mentioned this pull request Apr 11, 2022
Merged
7 tasks
alexcjohnson
alexcjohnson approved these changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 what a slog. Thanks for all the iterations @T4rk1n - let's see what Percy support says, whether there's a way for us to bring back their new SDK or not... for now at least this gets us onto the new rendered Firefox.

@alexcjohnson alexcjohnson merged commit adb6db7 into dev Apr 13, 2022
@alexcjohnson alexcjohnson deleted the fix-ci branch April 13, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T4rk1n @alexcjohnson