Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed dropdown bug #1908 #1958

Closed
wants to merge 7 commits into from
Closed

Conversation

AnnMarieW
Copy link
Collaborator

@AnnMarieW AnnMarieW commented Mar 4, 2022

Fixes #1908 Dropdown: Selected options not showing when the value contains a comma

As reported on the forum by Marcus

  • I have run the tests locally and they passed. (refer to testing section in contributing)

  • I have added entry in the CHANGELOG.md

@AnnMarieW AnnMarieW requested a review from alexcjohnson as a code owner March 4, 2022 21:37
@alexcjohnson
Copy link
Collaborator

@AnnMarieW the test you deleted makes sense to delete, it doesn't look like behavior we want. But can you add a test that shows the behavior that this PR fixes?

@AnnMarieW
Copy link
Collaborator Author

@alexcjohnson I added a test - looks like it's ready for another review

@AnnMarieW
Copy link
Collaborator Author

Closing this because it's now included in #1970

@AnnMarieW AnnMarieW closed this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Dropdown: Selected options not showing when the value contains a comma
2 participants