Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dash Table filter options position #1801

Merged
merged 11 commits into from
Oct 22, 2021

Conversation

akksi
Copy link
Contributor

@akksi akksi commented Oct 13, 2021

@akksi akksi force-pushed the fix/table-w-dropdown-alignment branch from 091cdec to 8253b97 Compare October 17, 2021 08:46
@akksi akksi marked this pull request as ready for review October 17, 2021 15:21
@akksi akksi requested a review from alexcjohnson as a code owner October 17, 2021 15:21
@alexcjohnson
Copy link
Collaborator

@akksi this looks great. I'm not sure what's going on with test_browser_smoke[Firefox] - all it says is
Service geckodriver unexpectedly exited. Status code was: 64
Which I don't see documented anywhere. This test runs just fine for me locally, as well as in the lint-unit-36 job, but seems to be failing repeatably in lint-unit-39.

Only thing I can think of is perhaps we're getting a new version of geckodriver that's incompatible with the version of Firefox on the test image circleci/python:3.9.2-buster-node-browsers - these images are deprecated in fact, and we really should update to the cimg series - perhaps cimg/python:3.9-browsers?

@akksi akksi force-pushed the fix/table-w-dropdown-alignment branch from 55f4f66 to caf80fa Compare October 22, 2021 16:05
@akksi
Copy link
Contributor Author

akksi commented Oct 22, 2021

@alexcjohnson I could finally solve the test issue by adding webdriver-manager to browser initialization, I updated the Docker image to a newer one anyway. Looks like it's working fine now. :)

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 - not sure what's up with webdriver-manager but if it works it works!

@alexcjohnson alexcjohnson merged commit deb8341 into plotly:dev Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"filter data..." text overlaps case insensitive icon
2 participants