Use flexbox for table header #1776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpacifitech
commented
Sep 23, 2021
Comment on lines
+519
to
535
| .column-header { | ||
| display: flex; | ||
| justify-content: space-between; | ||
|
|
||
| &--clear, | ||
| &--delete, | ||
| &--edit, | ||
| &--hide, | ||
| &--sort { | ||
| .not-selectable(); | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| > *:only-child { | ||
| margin-left: auto; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is the only changes on this less file.. other changes are just prettier fix.
|
Another fix for plotly/dash-table#867 |
akksi
suggested changes
Sep 24, 2021
There was a problem hiding this comment.
- Looks like one of the Percy tests is failing (https://app.circleci.com/pipelines/github/plotly/dash/2707/workflows/6936fe57-0c84-4d9f-b4b7-c47452fe9a6e/jobs/44310)
- If there are multiple buttons/icons in a column, they should be wrapped in a container so all of them would be aligned left OR, maybe it would work to always add
margin-left: autoto the text, so it will put the spacing between the icons and the text (I like the second solution better). - Do we need to keep the
float: leftproperties?
|
Looks like we had multiple parallel fixes for this... 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.