Updating CI Python images #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ jobs: | |||
|
|
|||
| artifacts: | |||
| docker: | |||
| - image: circleci/python:3.7.6-stretch-node-browsers | |||
| - image: circleci/python:3.7.9-stretch-node-browsers | |||
There was a problem hiding this comment.
Bump to latest patch version for each Python version, side-effect is that this updates the version of Chrome
There was a problem hiding this comment.
Two thoughts:
- should we switch to circleci's "next-gen" images? https://circleci.com/developer/images/image/cimg/python
- Maybe a bigger task, but should we be switching from py3.7 to py3.9?
There was a problem hiding this comment.
@alexcjohnson I can certainly look into those. If possible I'd like to do these in a follow up as this work was initiated by an issue @harryturr encountered as part of his current work assignment.
| @@ -431,6 +431,7 @@ def _get_chrome(self): | |||
|
|
|||
| capabilities = DesiredCapabilities.CHROME | |||
| capabilities["loggingPrefs"] = {"browser": "SEVERE"} | |||
| capabilities["goog:loggingPrefs"] = {"browser": "SEVERE"} | |||
There was a problem hiding this comment.
Add ChromeDriver 75+ correct capabilities. Keep the old one for compatibility.
| @@ -57,4 +57,4 @@ def apply_cors(response): | |||
| dash_duo.wait_for_element_by_id("btn").click() | |||
| dash_duo.wait_for_element("#output-0").text == "0=1" | |||
|
|
|||
| assert len(dash_duo.get_logs()) != 0 | |||
| assert dash_duo.get_logs() == [] | |||
There was a problem hiding this comment.
This log entry in Chrome 87 is a warning and now not included.
This was referenced Dec 17, 2020
Marc-Andre-Rivet
requested review from
alexcjohnson and
rpkyle
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've previously had issues moving to newer versions of these CI images, at least part of the issue seems to be that Chromedriver 75 changed a capabilities flag for logging.
https://chromedriver.chromium.org/downloads
This PR proposes to add the flag (while keeping the old one for non-core projects still using older CI images
Also changes expected behavior for
rdif001as as of Chrome 87 running this test only results in warnings, now correctly not being picked up byget_logs(). As of Chrome 89 this behavior will change and at least 1 error will be present. This will require the test to be updated again and to have a different behavior in Python 2.7 vs. 3.x unless we manually update the version of Chrome used in that test.