-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted fixes required for CRAN submission #1186
Conversation
@rpkyle I think we should drop
|
@alexcjohnson @Marc-Andre-Rivet This is ready for your review, and should resolve the CRAN maintainer concerns. I'd like to merge this today if possible, so Marc-André can use it for package builds starting with the upcoming Dash release. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💄 There are a bunch of places here the indentation is just changed from 4 to 8 spaces inside parens, either function args or if
conditions - please put back the original 4 spaces. Also there's a ._r_components_generation.py.swp
file committed -> should be .gitignore
'd?
Aside from that these changes look good to me!
Sure, not entirely understanding what happened there, but the linter demanded more spaces, so I added them. 🤷♂️ I can try removing them, but if it fails the check I'll have to determine what led to the (new) warnings. Will add the |
OK, restored in 06dbc8d. Will try to sort out why that happened, might be a difference in configuration between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should be retargeted to dev
now that #1078 is merged, yes? Anyway after that and the Windows build is sorted out I think it's ready to go! 💃
@alexcjohnson I've taken your advice (thanks! 👏 ) on removing the spaces within the I've opened https://github.com/plotly/dash-core/issues/184 in the meantime, and 019df65 will add back the spaces we have now omitted when necessary. |
* wrap descriptions at 60 chars * fix wildcard handling * support for non-CSS/JS deps in assets * add value tag for .Rd files * add copyright field to DESCRIPTION * add Authors@R line to DESCRIPTION * fix --r-suggests lstrip bug * +sp after , if missing in R imp/sugg/deps
This PR proposes several enhancements and minor fixes in the R package generator, based on requests from CRAN maintainers:
support for arbitrary file extensions in component library assets (required by Provide support for arbitrary file extensions within Dash for R component libraries dashR#186)superseded by Issue 481 - Support arbitrary file extensions in component suites #1078Authors@R
field withinDESCRIPTION
\value
field to all.Rd
files for exported methods and "explain function results". for functions returning no value, document as\value{None}
.cph
role attributes in theAuthors@R
field, or by using aCopyright
field.Specifically, two new YAML keys are supported in
dash-info.yaml
:pkg_copyright
: when present, will add in aCopyright:
line including the string value (see https://cran.r-project.org/web/packages/policies.html)pkg_authors
: when present,dash-generate-components
will use this string as-is forAuthors@R:
, which CRAN prefers toAuthor:
andMaintainer:
elements withinDESCRIPTION
. When this string is not present, the generator will create it based on theauthor
key withinpackage.json
, and assume that the author is the maintainer.