Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard dash interface for location change #1094

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Conversation

Marc-Andre-Rivet
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet commented Jan 27, 2020

Provide an official API to listen and trigger location path events.
This is currently handled with undocumented / hidden events in dcc.Link, dcc.Location and other component libraries depending on these hidden values.

@plotly/dash-component-plugins will be bumped to 1.1.0.

@Marc-Andre-Rivet Marc-Andre-Rivet changed the title - add standard dash interface for location change Add standard dash interface for location change Jan 27, 2020
@Marc-Andre-Rivet Marc-Andre-Rivet marked this pull request as ready for review January 27, 2020 16:23
Copy link
Contributor

@wbrgss wbrgss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to fix plotly/dash-design-kit#675 (private repo) together with plotly/dash-design-kit#716 and #1094

💃 💃 Clean and robust solution!

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit cfd091b into dev Jan 29, 2020
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the links-events branch January 29, 2020 01:23
nightsailer added a commit to o3cloud/dash that referenced this pull request Feb 23, 2020
* Add standard dash interface for location change (plotly#1094)

* feat: disable cookie access under restricted sandboxes (plotly#1080)

* IE11 compatibility (plotly#1106)

* Add `inheritAsyncDecorator` for wrapper components (plotly#1109)

* bump version, loosen version requirements

* dcc>=1.7.0, 1.7.1 was JS only

* stricten versions

* stricten table version

Co-authored-by: Marc-André Rivet <Marc-Andre-Rivet@users.noreply.github.com>
Co-authored-by: Jose Diaz-Gonzalez <email@josediazgonzalez.com>
nightsailer added a commit to o3cloud/dash that referenced this pull request Feb 23, 2020
* Add standard dash interface for location change (plotly#1094)

* feat: disable cookie access under restricted sandboxes (plotly#1080)

* IE11 compatibility (plotly#1106)

* Add `inheritAsyncDecorator` for wrapper components (plotly#1109)

* bump version, loosen version requirements

* dcc>=1.7.0, 1.7.1 was JS only

* stricten versions

* stricten table version

Co-authored-by: Marc-André Rivet <Marc-Andre-Rivet@users.noreply.github.com>
Co-authored-by: Jose Diaz-Gonzalez <email@josediazgonzalez.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants