Merge pull request #365 from plotly/fix-init-configs

Fix url_base_pathname init configs
plotly · Sep 6, 2018 · 78b84ca · 78b84ca
2 parents 7219b3d + 9959758
commit 78b84ca
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 6 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -15,8 +15,12 @@ jobs:
           name: Write deps cache key
           command: cat "$REQUIREMENTS_FILE" > reqs.txt
 
+      - run:
+          name: Write job name
+          command: echo $CIRCLE_JOB > circlejob.txt
+
       - restore_cache:
-          key: deps1-{{ .Branch }}-{{ checksum "reqs.txt" }}
+          key: deps1-{{ .Branch }}-{{ checksum "reqs.txt" }}-{{ checksum ".circleci/config.yml" }}-{{ checksum "circlejob.txt" }}
 
       - run:
           name: Install dependencies
@@ -27,7 +31,7 @@ jobs:
               pip install -r $REQUIREMENTS_FILE
 
       - save_cache:
-          key: deps1-{{ .Branch }}-{{ checksum "reqs.txt" }}
+          key: deps1-{{ .Branch }}-{{ checksum "reqs.txt" }}-{{ checksum ".circleci/config.yml" }}-{{ checksum "circlejob.txt" }}
           paths:
               - "venv"
 

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.26.4 - 2018-08-28
+## Fixed
+- Set `url_base_pathname` to `None` in `Dash.__init__`. Fix [#364](https://github.com/plotly/dash/issues/364)
+
 ## 0.26.3 - 2018-08-27
 ## Fixed
 - Prefix assets files with `requests_pathname_prefix`. [#351](https://github.com/plotly/dash/pull/351)

diff --git a/dash/dash.py b/dash/dash.py
@@ -76,7 +76,7 @@ def __init__(
             assets_url_path='/assets',
             assets_ignore='',
             include_assets_files=True,
-            url_base_pathname='/',
+            url_base_pathname=None,
             assets_external_path=None,
             requests_pathname_prefix=None,
             routes_pathname_prefix=None,

diff --git a/dash/version.py b/dash/version.py
@@ -1 +1 @@
-__version__ = '0.26.3'
+__version__ = '0.26.4'
diff --git a/dev-requirements-py37.txt b/dev-requirements-py37.txt
@@ -1,5 +1,5 @@
 dash_core_components>=0.27.2
-dash_html_components>=0.12.0rc3
+dash_html_components>=0.12.0
 dash-flow-example==0.0.3
 dash-dangerously-set-inner-html
 dash_renderer

diff --git a/requirements.txt b/requirements.txt
@@ -2,7 +2,7 @@ appnope==0.1.0
 backports.shutil-get-terminal-size==1.0.0
 click==6.7
 dash-core-components==0.3.3
-dash-html-components==0.11.0rc1
+dash-html-components==0.12.0
 dash-renderer==0.2.9
 dash.ly==0.14.0
 decorator==4.0.11