Skip to content

Commit

Permalink
Merge pull request #1015 from plotly/946-testing-entrypoint
Browse files Browse the repository at this point in the history
🔇 remove the warning as it might confuse non dash usage
  • Loading branch information
alexcjohnson authored Nov 22, 2019
2 parents 64fefff + 23bda86 commit 53d8fcc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
14 changes: 5 additions & 9 deletions dash/testing/plugin.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
# pylint: disable=missing-docstring,redefined-outer-name
import warnings
import pytest
from .consts import SELENIUM_GRID_DEFAULT


try:
import pytest

from dash.testing.application_runners import (
ThreadedRunner,
ProcessRunner,
Expand All @@ -14,17 +12,15 @@
from dash.testing.browser import Browser
from dash.testing.composite import DashComposite, DashRComposite
except ImportError:
warnings.warn("run `pip install dash[testing]` if you need dash.testing")

WEBDRIVERS = {"Chrome", "Firefox"}
pass


def pytest_addoption(parser):
dash = parser.getgroup("Dash", "Dash Integration Tests")

dash.addoption(
"--webdriver",
choices=tuple(WEBDRIVERS),
choices=("Chrome", "Firefox"),
default="Chrome",
help="Name of the selenium driver to use",
)
Expand All @@ -51,8 +47,8 @@ def pytest_addoption(parser):
dash.addoption(
"--percy-assets",
action="store",
default='tests/assets',
help="configure how Percy will discover your app's assets"
default="tests/assets",
help="configure how Percy will discover your app's assets",
)

dash.addoption(
Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def read_req_file(req_type):
long_description=io.open("README.md", encoding="utf-8").read(),
long_description_content_type="text/markdown",
install_requires=read_req_file("install"),
python_requires=">=2.7, !=3.0.*, !=3.1.*, !=3.2.*",
extras_require={
"dev": read_req_file("dev"),
"testing": read_req_file("testing"),
Expand Down

0 comments on commit 53d8fcc

Please sign in to comment.