Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

IE11 compatibility #637

Merged
merged 45 commits into from
Nov 14, 2019
Merged
Show file tree
Hide file tree
Changes from 40 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
90953a3
update exclude, dynamic plugin
Nov 7, 2019
c7fed23
- es5 check on artifacts
Nov 7, 2019
4543822
rc of @plotly/dash-component-plugins
Nov 8, 2019
39daee3
bump dash-component-plugins
Nov 8, 2019
8e94646
polyfill tests
Nov 8, 2019
8b9b76e
no exclude the exclude
Nov 8, 2019
f4d5c64
bump @plotly/webpack-dash-dynamic-import
Nov 8, 2019
0663d8c
@babel/polyfill in standalone tests
Nov 8, 2019
2acb59e
standalone tests configuration
Nov 8, 2019
1587148
npm ci
Nov 8, 2019
24c9a8b
update lock
Nov 8, 2019
1123a88
revert
Nov 8, 2019
64830cb
options
Nov 8, 2019
17cfa0e
concat entries
Nov 8, 2019
e73a48f
...
Nov 8, 2019
d74a86d
@plotly/webpack-dash-dynamic-import rc
Nov 8, 2019
9fc72fa
bump @plotly/webpack-dash-dynamic-import (safe check)
Nov 8, 2019
559371b
bump @plotly/webpack-dash-dynamic-import (safe check)
Nov 8, 2019
91bc5da
async test
Nov 8, 2019
078eba4
update docker
Nov 8, 2019
64c7125
revert for standalone
Nov 8, 2019
e8e5198
update cypress to 3.6.0
Nov 8, 2019
ff1f6a0
increase timeout: tests are unstable for unknown reasons
Nov 8, 2019
168b93f
3.6.7
Nov 8, 2019
747f6cb
3.6 once again? insane timeout.. can this ever pass correctly?
Nov 8, 2019
9564405
undo cypress settings changes
Nov 12, 2019
29732d4
selectively apply focus
Nov 12, 2019
aca7b4f
fix test - pressing a release:false key presses it again in cypress 3…
Nov 12, 2019
5b21efa
old standalone
Nov 12, 2019
9d3d97c
undo cypress 3.6.0 -> 3.4.1
Nov 12, 2019
45f04c2
^3.4.1
Nov 12, 2019
ad7600b
cypress 3.6.1
Nov 12, 2019
4127bd9
old cypress for standalone
Nov 12, 2019
aaf950b
legacy standalone all the way
Nov 12, 2019
6289143
update changelog
Nov 12, 2019
28c73dd
use dash from 1003-dash-ie11
Nov 12, 2019
ae4e680
clean up applyFocus logic
Nov 13, 2019
b137ed8
loading_state changes
Nov 13, 2019
9e46f0d
alignment
Nov 13, 2019
eb268c0
- additional tests to make sure the table neither loses or yanks focu…
Nov 13, 2019
66c7294
revert test change // fails in cypress 3.6.1
Nov 13, 2019
1e4d140
it.only
Nov 13, 2019
d16c878
babel-plugin-transform-regenerator
Nov 13, 2019
145db8d
undo -b 1003-dash-ie11
Nov 14, 2019
eff508d
build.watch, babel polyfills
Nov 14, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2
jobs:
"server-test":
docker:
- image: circleci/python:3.6.7-node-browsers
- image: circleci/python:3.6-node-browsers
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlocking to use latest.

- image: cypress/base:10

steps:
Expand All @@ -12,7 +12,7 @@ jobs:
key: deps1-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }}
- run:
name: Install npm packages
command: npm install
command: npm ci
- run:
name: Cypress Install
command: |
Expand All @@ -31,7 +31,7 @@ jobs:
python -m venv venv || virtualenv venv
. venv/bin/activate
pip install -r dev-requirements.txt --quiet
git clone --depth 1 git@github.com:plotly/dash.git dash-main
git clone --depth 1 -b 1003-dash-ie11 git@github.com:plotly/dash.git dash-main
pip install -e ./dash-main[dev] --quiet

- run:
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:
key: deps1-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }}
- run:
name: Install npm packages
command: npm install
command: npm ci
- run:
name: Cypress Install
command: |
Expand All @@ -74,12 +74,15 @@ jobs:

- run:
name: Run tests
command: npm run test.standalone
command: |
rm -rf node_modules/cypress
npm i cypress@3.4.1
npm run test.standalone


"unit-test":
docker:
- image: circleci/python:3.6.7-node-browsers
- image: circleci/python:3.6-node-browsers
- image: cypress/base:10

steps:
Expand All @@ -88,7 +91,7 @@ jobs:
key: deps1-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }}
- run:
name: Install npm packages
command: npm install
command: npm ci
- run:
name: Cypress Install
command: |
Expand All @@ -107,7 +110,7 @@ jobs:
python -m venv venv || virtualenv venv
. venv/bin/activate
pip install -r dev-requirements.txt --quiet
git clone --depth 1 git@github.com:plotly/dash.git dash-main
git clone --depth 1 -b 1003-dash-ie11 git@github.com:plotly/dash.git dash-main
pip install -e ./dash-main[dev] --quiet

- run:
Expand Down Expand Up @@ -148,7 +151,7 @@ jobs:

"node":
docker:
- image: circleci/python:3.6.7-node
- image: circleci/python:3.6-node

steps:
- checkout
Expand Down Expand Up @@ -185,7 +188,7 @@ jobs:

"python-3.6":
docker:
- image: circleci/python:3.6.7-stretch-node-browsers
- image: circleci/python:3.6-stretch-node-browsers

environment:
PERCY_ENABLED: True
Expand All @@ -206,13 +209,13 @@ jobs:
python -m venv venv || virtualenv venv
. venv/bin/activate
pip install -r dev-requirements.txt --quiet
npm install
npm ci

- run:
name: Install dependencies (dash)
command: |
. venv/bin/activate
git clone --depth 1 git@github.com:plotly/dash.git dash-main
git clone --depth 1 -b 1003-dash-ie11 git@github.com:plotly/dash.git dash-main
pip install -e ./dash-main[dev,testing] --quiet
cd dash-main/dash-renderer && npm run build && pip install -e . && cd ../..

Expand Down
10 changes: 4 additions & 6 deletions .config/webpack/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,18 @@ const dashLibraryName = packagejson.name.replace(/-/g, '_');

module.exports = (options = {}) => {
const babel = options.babel || undefined;
const entry = options.entry || [];
const preprocessor = basePreprocessing(options.preprocessor);
const mode = options.mode || 'development';
const ts = options.ts || {};

console.log('********** Webpack Environment Overrides **********');
console.log('Preprocessor', JSON.stringify(preprocessor));
console.log('mode', mode);
console.log('babel', JSON.stringify(babel));
console.log('ts', JSON.stringify(ts));
console.log('options', JSON.stringify(options));

return {
entry: {
bundle: './src/dash-table/index.ts',
demo: ['./demo/index.html', './demo/index.js']
bundle: entry.concat(['./src/dash-table/index.ts']),
demo: entry.concat(['./demo/index.html', './demo/index.js'])
},
mode: mode,
output: {
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixes
- [#637](https://github.com/plotly/dash-table/pull/637) Fix multiple issues
- Fix IE11 compatibility issues and add ES5 compatibility and validation
- Fix a bug with `loading_state` being handled incorrectly, causing the table to steal focus

## [4.5.0] - 2019-10-29
### Changed
- [#554](https://github.com/plotly/dash-table/pull/554) Async loading of `xlsx` library on export
Expand Down
16 changes: 2 additions & 14 deletions babel.config.js
Original file line number Diff line number Diff line change
@@ -1,22 +1,10 @@
const presets = [
['@babel/env', {
targets: {
browsers: [
'last 2 Chrome versions',
'last 2 Firefox versions',
'last 2 Safari versions',
'last 2 Edge versions',
'Explorer 11'
]
},
useBuiltIns: 'usage',
corejs: 3
}],
'@babel/preset-env',
'@babel/preset-react'
];

const plugins = [
'@babel/plugin-syntax-dynamic-import'
];

module.exports = { presets };
module.exports = { presets, plugins };
Loading