This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Async table component #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| 'relative_package_path': 'async~table.js', | ||
| 'external_url': ( | ||
| 'https://unpkg.com/dash-table@{}/dash_table/async~table.js' |
There was a problem hiding this comment.
Oh... is external serving going to work with fingerprints?
|
Seems straightforward... but I thought earlier you decided against doing this, like it wasn't going to help that much. What changed your mind? |
|
@alexcjohnson It doesn't help much for a small app but I came to realize that for a large modular app like the docs, doing this across all core component packages greatly reduces the qty of JS that needs to be fetched in order for the app to start working. |
alexcjohnson
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
My comment about external was addressed in plotly/dash#973 - this one looks great! 💃
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to plotly/dash#973 to be completed and
@plotly/webpack-dash-dynamic-importto be updated / published in order to be completed.Makes the entire table component async. As the table has side-effects (like the dcc.Graph), it needs to inform the renderer by using the
@plotly/dash-component-pluginsdecorator.