-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
…all. Update store to not use logger in production build
Add package-lock.json for install. Update store to not use logger in production build. Add docstring to initializeStore
Looks good to me, thanks @mjclawar ! It looks like tests aren't running, I suspect because this is a forked branch. I'll update those settings. |
OK @mjclawar , I believe that forks should now trigger tests. Could you try pushing something up again? |
@chriddyp Tests all pass on my local machine -- any ideas why that one failed? |
Hm, I suspect that it's intermittent. I'll re-run the tests |
is supposed to fire the callback We should probably update the test with something like:
or something more solid like text = 'hello world'
for (i, char) in enumerate(text):
input_1.send_keys(char)
wait_for_text_to_equal('output', text[:i]) Anyway, we don't need to fix that in this PR. I've logged the issue in #38 |
@chriddyp do you need anything else from me to merge this PR in and update? Thanks! |
@mjclawar Thanks for checking in! No I don't, just need to re-run CI a couple times until everything pases. Circle passes but it looks like Percy had a gateway timeout on the last run. |
@mjclawar Thanks for reminder! I just published to npm and pypi |
This PR uses the
process.env.NODE_ENV
to avoid adding logging to the redux middleware in the production build.Closes #35
Other changes
package-lock.json
.idea/
to gitignore for IntelliJ editorsinitializeStore
function.