This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Clientside Callbacks #143
Merged
Clientside Callbacks #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(so that clientside can use it - see next commit)
chriddyp
added a commit
to plotly/dash
that referenced
this pull request
Mar 30, 2019
see associated PR & examples in plotly/dash-renderer#143
Getting an issue with Percy on “finalizing builds” - might be related to parallelization (https://docs.percy.io/docs/parallel-test-suites). So, try just moving the clientside tests into the `test_render` file
so that the community can unambiguously refer to this feature as “clientside” rather than “client” also use new `dash` `clientside_callback`
so that circle pulls the latest dash commits
.circleci/config.yml
Outdated
| @@ -43,6 +43,7 @@ jobs: | |||
| git clone git@github.com:plotly/dash-html-components.git | |||
| git clone git@github.com:plotly/dash-table.git | |||
| . venv/bin/activate | |||
| cd dash && git checkout clientside-2 && cd .. | |||
There was a problem hiding this comment.
Note: You can also do add -b clientside-2 in the git clone command above.
There was a problem hiding this comment.
non-⛔️ as this line will disappear when the companion PR merges... but we may benefit 🐎 from using a shallow clone git clone -depth=1 on CI, in which case -b <branch> may be the required method.
closer to the one in dash, but there are a few extra features in here: - works with inputs (`el.text` for an input is `’’`, you have to check `get_attribute(‘value’)` - prints out some nicer assertion strings
|
Alright, thanks everyone for your review. I believe I have addressed y'alls comments now. |
alexcjohnson
approved these changes
Apr 6, 2019
chriddyp
added a commit
to plotly/dash
that referenced
this pull request
Apr 8, 2019
* 🐎 clientside callback interface see associated PR & examples in plotly/dash-renderer#143 * 📝 don't overload `callback` with `clientside` and rename `client_function` to `clientside_function * ✅ straighten up the pylint directives as per #672 (comment) * ⚡ No clientside function = `None` * 📝 CHANGELOG * 📝 pylint * ⚡ unused files
denis554
added a commit
to denis554/dash
that referenced
this pull request
Apr 9, 2019
* 🐎 clientside callback interface see associated PR & examples in plotly/dash-renderer#143 * 📝 don't overload `callback` with `clientside` and rename `client_function` to `clientside_function * ✅ straighten up the pylint directives as per plotly/dash#672 (comment) * ⚡ No clientside function = `None` * 📝 CHANGELOG * 📝 pylint * ⚡ unused files
This was referenced Sep 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next version of #142, incorporating feedback described in #142 (comment)
Same examples as in #142 will run, however the syntax is a little closer to the python callbacks now. See an associated PR in
dashI've pushed up the examples in 5b9934d, I'll remove them before merging this PR. Same GIFs as in #142.