Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async ColorPicker and Slider #70

Merged
merged 6 commits into from
Nov 5, 2019
Merged

Async ColorPicker and Slider #70

merged 6 commits into from
Nov 5, 2019

Conversation

Marc-Andre-Rivet
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet commented Oct 24, 2019

Followup to plotly/dash#973

** Finalizing this will require dash==1.5.0 with async support to be released and updating the @plotly/webpack-dash-dynamic-import plugin to 1.1.0

@Marc-Andre-Rivet Marc-Andre-Rivet changed the title Async ColorPicker and Slider [WIP] Async ColorPicker and Slider Oct 24, 2019
- update deps
- artifacts
@Marc-Andre-Rivet Marc-Andre-Rivet marked this pull request as ready for review November 4, 2019 14:41
@Marc-Andre-Rivet Marc-Andre-Rivet changed the title [WIP] Async ColorPicker and Slider Async ColorPicker and Slider Nov 4, 2019
@Marc-Andre-Rivet
Copy link
Contributor Author

Side-quest for later: #71 -- as this project doesn't have CI setup

@Marc-Andre-Rivet Marc-Andre-Rivet added this to the Dash v1.7 milestone Nov 5, 2019
Copy link
Contributor

@shammamah-zz shammamah-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small questions, but otherwise LGTM 💃

@shammamah-zz
Copy link
Contributor

💃 Looks good to me!

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit 9f29132 into master Nov 5, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the exp-dynamic branch November 5, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants