Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filename in setup.py #78

Merged
merged 2 commits into from
Sep 24, 2019
Merged

Conversation

LuAPi
Copy link
Contributor

@LuAPi LuAPi commented Aug 23, 2019

Running python setup.py sdist on a project that's been copied with cookiecutter doesn't work because it can't find package.json in the subdirectory named after the project.

I'm not actually sure if this is the correct fix because there are two identical files in a repo setup by cookiecutter:

./package.json
./{{cookiecutter.project_shortname}}/package-info.json

I wasn't totally sure whether to use this fix:

with open(os.path.join('{{cookiecutter.project_shortname}}', 'package-info.json')) as f:

or this one:

with open('package.json') as f:

Both seem to work.

@alexcjohnson
Copy link
Collaborator

Closes #81 (the piece of it that wasn't closed by #86)

@alexcjohnson alexcjohnson self-assigned this Sep 24, 2019
@alexcjohnson alexcjohnson removed their assignment Sep 24, 2019
Co-Authored-By: alexcjohnson <johnson.alex.c@gmail.com>
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 thanks again!

@alexcjohnson alexcjohnson merged commit 2e2747b into plotly:master Sep 24, 2019
@LuAPi LuAPi deleted the fix-python-dist branch October 7, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants