-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Genome viewer #115
[WIP] Genome viewer #115
Conversation
@emmanuelle is the pileup.css imported properly? otherwise it might be better to just make a thin dash wrapper on top of the react repo (see oncoprint, alignment viewer), let me push to npm in that case |
Might have something to do with the fact that pileup only accepts file paths not files |
@jackluo thank you very much for your help! For the css file, I put in the About file paths, it's true that the parts of the app which doesn't display is linked to local files. However, in your |
Unfortunately I don't get meaningful error messages; however the console says "RangeError: Offsets are out of bounds". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files under genome_data
should be stored under tests/dash/sample_data
(we should add the name of the app in front of the file names, I will create an issue for that)
@jackluo Indeed, when I put the files on a web server and put the URLs in the app (instead of relative paths) it works ok. Any idea of how to pass local files to the app? (what puzzles me is that it works perfectly in your App.js in react-genome-viewer) |
The way that we provide css stylesheets in packages is different from the way that we use stylesheets in dash apps. For packages, we need to explicitly include them in the package. This involves:
The external URL is the URL that is autopublished to the unpkg cdn when we publish to NPM. The
So, when you are testing locally in a Dash app, adding the css to Let me know if that makes sense! |
@chriddyp thanks for the explanations. Yes, I think it makes sense but at the moment there is no css file included in the package file, the ones of the other components are all in |
OK, maybe it's that the other css files are used only by apps and not by components? I'll look into this more tomorrow. Thanks once again! |
Oops I closed the PR by accident, could an owner please re-open it? |
@jackluo, as I understand, |
Now I need to find a way to serve files, maybe I can use this plotly/dash#71 |
Yeah exactly - we'll need to break out the CSS files into "demo app" stylesheets & "package/component" stylesheets |
Dash Bio pull request
Name and description of your component
GenomeViewer, from https://github.com/plotly/react-genome-viewer by @jackluo. A tool for visualization and comparison of genome sequences, built on top of pileup.js
Main libraries used in component
I added the GenomeViewer component from the
react-genome-viewer
. This is still work in progress, for some reason I cannot generate all tracks as show on the image below. @jackluo any idea why the coverage, variants or alignments track are not displayed correctly? I'll be working on it but ideas are welcome!to be compared to the
react-genome-viewer
repo