Use Dash's create_callback_id to get the callback id #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexcjohnson if you could have a quick look at this one as well 🙏 |
|
Hey Renaud, I'll have the team take a look as this. For future reference feel free to tag myself or @gvwilson if you have any questions on GH. That being said as this adds new functionality to the package I am not immediately sure whether we will accept this PR. |
|
Hey @ndrezn this isn't new functionality, it's a fix. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current public_callback decorator wasn't working well in some cases, including when using dash-extension's DashProxy.
This PR leverages Dash's internal
create_callback_idto retrieve the callback id to be marked as public.Also copied test updated from #162 as this PR supersedes the fix in there.