adapt devtools test_prop_check suite

`invalid-nested-prop` became `allow-nested-prop` in dash 2.1.0 moreover, use same css query as in the python version of the `test_props_check.py` suite
plotly · Jun 21, 2023 · 95d0561 · 95d0561
1 parent 6eb9c06
commit 95d0561
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/test/integration/devtools/jl_props_check/jldvpc001_prop_check_errors_with_path.jl b/test/integration/devtools/jl_props_check/jldvpc001_prop_check_errors_with_path.jl
@@ -13,12 +13,6 @@ test_cases = Dict(
         "component"=> dcc_checklist,
         "props"=> (options = [Dict("label" => "hello")], value = ["test"]),
     ),
-    "invalid-nested-prop"=> Dict(
-        "fail"=> true,
-        "name"=> "invalid nested prop",
-        "component"=> dcc_checklist,
-        "props"=> (options = [Dict("label"=> "hello", "value"=> true)], value = ["test"]),
-    ),
     "invalid-arrayOf"=> Dict(
         "fail"=> true,
         "name"=> "invalid arrayOf",
@@ -73,6 +67,12 @@ test_cases = Dict(
         "component"=> html_div,
         "props"=> (children = Dict("hello" => "world"),),
     ),
+    "allow-nested-prop"=> Dict(
+        "fail"=> false,
+        "name"=> "allow nested prop",
+        "component"=> dcc_checklist,
+        "props"=> (options = [Dict("label"=> "hello", "value"=> true)], value = ["test"]),
+    ),
     "allow-null-2"=> Dict(
         "fail"=> false,
         "name"=> "allow null as value",

diff --git a/test/integration/devtools/test_props_check.py b/test/integration/devtools/test_props_check.py
@@ -16,10 +16,6 @@ def jl_test_file_path(filename):
         "fail": True,
         "name": 'missing required "value" inside options',
     },
-    "invalid-nested-prop": {
-        "fail": True,
-        "name": "invalid nested prop",
-    },
     "invalid-arrayOf": {
         "fail": True,
         "name": "invalid arrayOf",
@@ -56,6 +52,10 @@ def jl_test_file_path(filename):
         "fail": True,
         "name": "returning a dictionary",
     },
+    "allow-nested-prop": {
+        "fail": False,
+        "name": "allow nested prop",
+    },
     "allow-null-2": {
         "fail": False,
         "name": "allow null as value",
@@ -99,6 +99,7 @@ def test_jldvpc001_prop_check_errors_with_path(dashjl):
 
         if test_cases[tc]["fail"]:
             dashjl.wait_for_element(".test-devtools-error-toggle", timeout=10).click()
-            dashjl.wait_for_element(".dash-error-card")
+            dashjl.wait_for_element(".dash-fe-error__info")
         else:
             dashjl.wait_for_element("#new-component", timeout=2)
+            dashjl.wait_for_no_elements(".test-devtools-error-toggle")