Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Travis always mails to hardcoded email address #208

Closed
mauritsvanrees opened this issue Aug 9, 2017 · 0 comments
Closed

Generated Travis always mails to hardcoded email address #208

mauritsvanrees opened this issue Aug 9, 2017 · 0 comments

Comments

@mauritsvanrees
Copy link
Member

The generated .travis.yml contains notifications: email: - <some email>. For every travis run, this sends an email only to this address. The actual committer does not get an email, unless they are the same person. It happened to me: I had my email address in a fresh repo, and then my colleague Fred did a commit and pushed it, but it contained an error. The Travis message was only delivered to me and not to him.

That is not good: the committer or pull request creator should get an email. And that is the default if you do not set anything here. See https://docs.travis-ci.com/user/notifications for more info.

So we should remove these settings. Or am I misinterpreting this?

mauritsvanrees added a commit that referenced this issue Feb 5, 2018
Until now only the creator of the package would get a notification, instead of the committer.
Fixes #208.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant