-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannot compute exact p-value #23
Comments
More generally I got warning that are not printed:
should we worry about them? I am not familiar with R, so I am not quite sure what its philosophy is with numerical warnings. |
warnings are not usually bad, but if you can run the commands in an interactive session try running warnings() just after running the command. Post the output here and we can check. |
Hey, since it's Martin Ménégoz who coded this script, I will transfer the request to him directly and invite him to answer here. |
or if you can't run interactively, try adding a warnings() statement just after the ks.test() statement. |
I think that we do not have to worry about these warnings. It just means that the computing of the p-value has been done with some simplifications, as explained there: https://stats.stackexchange.com/questions/113032/ks-test-and-ks-boot-exact-p-values-and-ties |
I added
in the code to get the warnings printed. I have only two kind of warnings, the first one already mentioned in the OP:
which I understand we should not worry about, and the second one:
which is fixed in aa3a75b |
I got this Warning message:
How should it be interpreted? Can it be ignored or does the code need to deal with this warning? I did not spot anything spurious in the plots.
The text was updated successfully, but these errors were encountered: