Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot compute exact p-value #23

Open
plesager opened this issue Mar 12, 2018 · 6 comments
Open

cannot compute exact p-value #23

plesager opened this issue Mar 12, 2018 · 6 comments
Labels
reproducibility related to that specific sub-project

Comments

@plesager
Copy link
Owner

I got this Warning message:

In ks.test(index_exp1, index_exp2) : cannot compute exact p-value with ties

How should it be interpreted? Can it be ignored or does the code need to deal with this warning? I did not spot anything spurious in the plots.

@plesager plesager added the reproducibility related to that specific sub-project label Mar 12, 2018
@plesager
Copy link
Owner Author

More generally I got warning that are not printed:

There were 13 warnings (use warnings() to see them)

should we worry about them? I am not familiar with R, so I am not quite sure what its philosophy is with numerical warnings.

@etiennesky
Copy link
Contributor

warnings are not usually bad, but if you can run the commands in an interactive session try running warnings() just after running the command. Post the output here and we can check.

@fmassonn
Copy link

Hey, since it's Martin Ménégoz who coded this script, I will transfer the request to him directly and invite him to answer here.

@etiennesky
Copy link
Contributor

or if you can't run interactively, try adding a warnings() statement just after the ks.test() statement.

@mmenegoz
Copy link

I think that we do not have to worry about these warnings. It just means that the computing of the p-value has been done with some simplifications, as explained there:

https://stats.stackexchange.com/questions/113032/ks-test-and-ks-boot-exact-p-values-and-ties

@plesager
Copy link
Owner Author

I added

options(warn=1)

in the code to get the warnings printed. I have only two kind of warnings, the first one already mentioned in the OP:

In ks.test(index_exp1, index_exp2) : cannot compute exact p-value with ties

which I understand we should not worry about, and the second one:

Warning: ! Warning: Parameter 'sizetit' is obsolete. Use 'title_scale' instead.

which is fixed in aa3a75b

plesager added a commit that referenced this issue Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reproducibility related to that specific sub-project
Projects
None yet
Development

No branches or pull requests

4 participants