CI with GitHub Actions #477
Conversation
Replaced the existing Travis configuration with the GitHub Actions configuration. I used the play-json configuration as a reference, especially for publish.yml. I've confirmed that the validation and testing work, but I haven't been able to confirm that the release works. Notifications to Gitter have not been migrated. (I wonder if this Gitter channel is still active?)
There was a problem hiding this comment.
Thanks a lot @tototoshi
This is looking good. There are a few things missing though. See my comments below.
Also, we will need to change mergify (see https://github.com/playframework/play-ws/pull/639/files#diff-6a30e47dd51449847422017b16878889b848f6602ac56d5a2e67ce8a19afade2).
But maybe we should do that on a follow-up PR. So first we get it running in GH Actions and merged. Then we remove Travis and adapt Merfigy.
|
One suggestion I would add for this would be https://github.com/djspiewak/sbt-github-actions which can automate the yaml generation and be an extra check. But IMHO I would do that as a follow up pr |
|
sbt-github-actions is great, but it seems we have playframework/.github now and it is used in play-json. |
|
Fixed with #483 |
Replaced the existing Travis configuration with the GitHub Actions configuration.
I used the play-json configuration as a reference, especially for publish.yml.
I've confirmed that the validation and testing work, but I haven't been able to confirm that the release works.
Notifications to Gitter have not been migrated. (I wonder if this Gitter channel is still active?)