We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug When accessing the site settings, an exception is raised. The regression was created at #10837
PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function PKP\components\forms\announcement\PKPAnnouncementForm::__construct(), 4 passed in C:\work\pkp\3.4\ojs\lib\pkp\pages\admin\AdminHandler.php on line 209 and exactly 6 expected in C:\work\pkp\3.4\ojs\lib\pkp\classes\components\forms\announcement\PKPAnnouncementForm.php:49 Stack trace: #0 C:\work\pkp\3.4\ojs\lib\pkp\pages\admin\AdminHandler.php(209): PKP\components\forms\announcement\PKPAnnouncementForm->__construct('http://localhos...', Array, 'http://localhos...', 'http://localhos...') #1 [internal function]: PKP\pages\admin\AdminHandler->settings(Array, Object(APP\core\Request)) #2 C:\work\pkp\3.4\ojs\lib\pkp\classes\core\PKPRouter.php(334): call_user_func(Array, Array, Object(APP\core\Request)) #3 C:\work\pkp\3.4\ojs\lib\pkp\classes\core\PKPPageRouter.php(278): PKP\core\PKPRouter->_authorizeInitializeAndCallRequest(Array, Object(APP\core\Request), Array, false) #4 C:\work\pkp\3.4\ojs\lib\pkp\classes\core\Dispatcher.php(165): PKP\core\PKPPageRouter->route(Object(APP\core\Request)) #5 C:\work\pkp\3.4\ojs\lib\pkp\classes\core\PKPApplication.php(395): PKP\core\Dispatcher->dispatch(Object(APP\core\Request)) #6 C:\work\pkp\3.4\ojs\index.php(22): PKP\core\PKPApplication->execute() #7 {main} thrown in C:\work\pkp\3.4\ojs\lib\pkp\classes\components\forms\announcement\PKPAnnouncementForm.php on line 49
Besides the exception, the argument position should also be fixed (required arguments shouldn't appear after optional ones).
In order to simulate it in OJS 3.4, it's needed to add a feature flag on the config.inc.php and also run a migration.
config.inc.php
To Reproduce
What application are you using? OJS 3.4
The text was updated successfully, but these errors were encountered:
pkp#10934 Fixed argument position
90d303c
pkp#10934 Namespaced constant
d585c0e
pkp#10934 Reused variables
1327579
pkp#10934 Added missing argument
e68368d
pkp/pkp-lib#10934 Submodule Update ##jonasraoni/bugfix-stable-3_4_0-1…
c4aaf27
…0934-fix-fatal-exception##
jonasraoni
Successfully merging a pull request may close this issue.
Describe the bug
When accessing the site settings, an exception is raised. The regression was created at #10837
Besides the exception, the argument position should also be fixed (required arguments shouldn't appear after optional ones).
In order to simulate it in OJS 3.4, it's needed to add a feature flag on the
config.inc.php
and also run a migration.To Reproduce
What application are you using?
OJS 3.4
The text was updated successfully, but these errors were encountered: