make the StatusError language tag optional #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. I have no issue with this change, but this will need a test so it does not regress in the future. |
Serialize and truncate a status message to exclude the language tag, reporting a panic in doing so as a failure.
|
Thanks. I added a test to client_tests.go that would fail gracefully before the change in e6dc896 and passes after it. |
|
Perfect, thanks. |
davecheney
added a commit
that referenced
this pull request
Oct 31, 2015
make the StatusError language tag optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be more lenient with servers that don't implement the language tag part of status messages. Addresses issue #52