Fixes KeyError when retrieving empty but existing object from S3 #771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Attempt to fix the
KeyError
we have when reading an empty file from S3Motivation
When we try to retrieve an empty file from S3 we may have the following error
This PR catches the
KeyError
and send aget_object
query without any range to retrieve the data as suggested in the issueTests
I added a test, but it seems that the Moto lib provide the value
ActualObjectSize
even for empty objects so the code won't be tested...