Accept custom HTTP headers when reading over HTTP(S) #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
requested changes
Mar 12, 2019
|
Does this version look good? |
mpenkov
requested changes
Mar 13, 2019
piskvorky
requested changes
Mar 13, 2019
|
I added a unit test, but I wasn't able to understand why it didn't run (after reading the travis ci output). It seems like I did the exact same thing as the other unit tests. So I don't know why it failed. |
|
@mpenkov @piskvorky Any help? The output looks a little different than I remember from a couple months ago, but any points can still help = ) |
|
@canada11 Have you tried running the test locally? Does it pass? |
mpenkov
changed the title
mpenkov
approved these changes
Jul 18, 2019
|
OK, this looks good to merge. @canada11 Thank you for your efforts, and congrats on your first contribution to smart_open 🥇 Keep them coming! @interpolatio Thanks for helping us work out the unit test problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Http calls woudn't take headers before. I added two changes that allows http calls to now accept user defined headers for http calls.