Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Move unloaded tabs for Tree Style Tab: tabs can not be activated|switched via TST 3.4.1 (2020.3.6) #2504

Closed
drsvp opened this issue Mar 7, 2020 · 8 comments
Labels
extension-compatibility conflict with another addon fixed

Comments

@drsvp
Copy link

drsvp commented Mar 7, 2020

Following my update to TST 3.4.1 (2020.3.6) i can no longer activate|switch to tabs via TST; rather, i have to go to the default tabs bar in Ffox to activate|switch between tabs. Prior to the TST update, it switched tabs when clicked on.

Steps to reproduce:
• Place mouse cursor over tab to be switched to
• The color changes indicating focus
• Clicking on the tab(s) does not switch to|activate them
[note: clicking an X to close a tab via TST works normally]

i restarted Ffox once the issue started but it remains for me
i added no additional|new addons along with the TST update (i do still have 70+ other addons running, tho only a half dozen or so of those are tabs specific)

Ffox 73.0.1 (64bit)
TST 3.4.1 (2020.3.6); dark theme
Windows 7

Thanks!

@piroor
Copy link
Owner

piroor commented Mar 7, 2020

This looks similar to #2503. Do you use any other addon extends TST?

@drsvp
Copy link
Author

drsvp commented Mar 7, 2020

Indeed, i have Move Unloaded Tabs for TST installed; deactivating it corrected my issue; activating it again causes the issue to return for me.

jic, i had it installed prior to the TST update to 3.4.1 (2020.3.6) and did not have this issue.

?

@piroor
Copy link
Owner

piroor commented Mar 7, 2020

Thanks, I've confirmed the problem with installed Move unloaded tabs for Tree Style Tab.

@piroor piroor added extension-compatibility conflict with another addon and removed help wanted labels Mar 7, 2020
@piroor piroor changed the title tabs can not be activated|switched via TST 3.4.1 (2020.3.6) Incompatible with Move unloaded tabs for Tree Style Tab: tabs can not be activated|switched via TST 3.4.1 (2020.3.6) Mar 7, 2020
@piroor
Copy link
Owner

piroor commented Mar 7, 2020

I forgot that TST's tab activation behavior was changed at a version between TST 3.0.17 and TST 3.1.8. Before 3.0.x, TST switched tab focus at the timing onmousedown. But 3.1.8 and later switched tab focus at the timing onclick - after onmouseup. "Move unloaded tabs for Tree Style Tab" was initially developed for TST 2.x but it actually (and unexpectedly) became unneeded for the purpose described at its name.

@piroor
Copy link
Owner

piroor commented Mar 7, 2020

Hmm... I missed that the behavior was actually changed with the pull request https://github.com/piroor/treestyletab/pull/2306/files and I didn't mentioned that totally...

@piroor
Copy link
Owner

piroor commented Mar 7, 2020

I've uploaded TST 3.4.4 to AMO with the fix. Please wait for editor's review...

@drsvp
Copy link
Author

drsvp commented Mar 12, 2020

Just a quick confirmation that Mozilla has released an update of TST to v 3.4.6, March 12, 2012
More after i've had the time to put it through some routines... including reactivating Move unloaded tabs for Tree Style Tab ...

@drsvp
Copy link
Author

drsvp commented Mar 12, 2020

The issue with tabs in the TST sidebar being unswitchable with Move unloaded tabs for Tree Style Tab enabled seems to be resolved for me! Working as expected.
Thanks!

@piroor piroor closed this as completed Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension-compatibility conflict with another addon fixed
Projects
None yet
Development

No branches or pull requests

2 participants