Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show advertising message for initial install (or updated) to show sidebar panel manually #1369

Closed
staktrace opened this issue Sep 26, 2017 · 5 comments

Comments

@staktrace
Copy link

Short description

After upgrading to WebExtension version of TST, the sidebar doesn't automatically show. Filing this as a result of discussion on https://bugzilla.mozilla.org/show_bug.cgi?id=1403183

Steps to reproduce

  1. Start Firefox (version < 57) with clean profile.
  2. Install TST (non-webextension version)
  3. Update Firefox to 57. This should also update TST to 2.0 which is the WebExtension version

Expected result

When the WebExt version of TST is installed, the sidebar panel is made visible.

Actual result

It is not made visible. This makes it feel like TST is broken.

I originally filed a bug against Mozilla for this, https://bugzilla.mozilla.org/show_bug.cgi?id=1403183 but it's not considered a bug by the add-ons team. Instead the suggested fix is that TST open a new tab advising the user to make the sidebar visible.

@piroor piroor changed the title Upgrading to WebExtension version of TST leaves the sidebar closed initially Show advertising message for initial install (or updated) to show sidebar panel manually Sep 27, 2017
@piroor
Copy link
Owner

piroor commented Sep 27, 2017

Because it is not allowed that WebExtensions addon opens the sidebar automatically without any user action, I think it is the last solution left for us: showing announcement message at initial startup of TST 2.0.

@piroor
Copy link
Owner

piroor commented Sep 27, 2017

piroor added a commit that referenced this issue Sep 27, 2017
@piroor
Copy link
Owner

piroor commented Sep 27, 2017

Oops, I wrongly mark the commit is related to this... It should be #1038

@piroor
Copy link
Owner

piroor commented Sep 29, 2017

By recent commits, now a message tab is shown automatically when TST is updated from legacy to 2.0.

@piroor piroor closed this as completed Sep 29, 2017
@staktrace
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants